Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add password flag for backend authentication #199

Merged

Conversation

matthisholleville
Copy link
Contributor

Closes #180

📑 Description

The code modification added a password flag for backend authentication in the auth package. Previously, users had to enter their password in the terminal when authenticating with the chosen backend, but with this modification, they can provide the password as a flag when running the authentication command.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Signed-off-by: Matthis Holleville <matthish29@gmail.com>
@matthisholleville matthisholleville requested a review from a team as a code owner April 2, 2023 21:17
Copy link

@shivamdurgbuns shivamdurgbuns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thschue thschue merged commit 075a940 into k8sgpt-ai:main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: add --auth-string flag to auth
3 participants